Skip to content

Conversation

@cmccarthy1
Copy link
Contributor

@cmccarthy1 cmccarthy1 commented Sep 24, 2021

This change closes #63

@cmccarthy1 cmccarthy1 changed the title Updates to repo in line with #63 Updates to default timezone setting in datetime functionality Sep 24, 2021
@ralmgren1
Copy link

Did this ever get merged into the main branch? The code I pull still has the old version, with the timezone set to GMT.
I can see that this might fail the test in testthat/test-basic.R line 73, which explicitly expects timezone GMT, though on my installation it seems to pass all the tests. I would suggest changing line 72 of test-basic.R from

rdatetime <- as.POSIXct('2006-07-21 09:13:39', tz='GMT')

to

rdatetime <- as.POSIXct('2006-07-21 09:13:39', tz='UTC')
attr(rdatetime,'tzone') <- NULL

and then the test expect_equal(datetime, rdatetime) in current line 73, new line 74, should succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default timezones set on datetime

2 participants