Made api more Ruby-like and fixed some bugs. #4
Conversation
* Replace endpoint calls with new endpoint names * Comment out community features that are being overhauled
Upgrade to use the upcoming v2 API.
… support for unserialization
…ing-master Conflicts: README.md lib/shopsense/version.rb
There was a problem hiding this comment.
How about:
return nil unless opts.kind_of?(Hash)
I'd prefer not to raise an error. Perhaps incorporate a logger instance and log a WARN describing the malformed arguments.
There was a problem hiding this comment.
The method signature changed,s o client code would have to be updated. I think it would be rather confusing to return nil. If you prefer to maintain BC, you could change it to:
opts = {:search => opts} if opts.kind_of? String
There was a problem hiding this comment.
I wouldn't really consider that backward compatibility since the name of the method is changing but a nice feature and a good alternative for raising an error.
There was a problem hiding this comment.
Can you update the doc to reflect the opts param change.
|
Hey. Sorry for the silence - I've been on holidays and is generally way too busy. I'll see if I can find the time to look at your comments within the next couple of days. |
3 participants
These are some changes that I made a while back. I thought the api was maintained by shopstyle, so I submitted the PR to the wrong fork. Here it is again.