fix some bugs

[JoeyHwong-gk]

• Fix Service-Independent File Leakage Issue.
• Support for Multiple Camera Streams in SparkRTC Mode

Summary by CodeRabbit

• Refactor: Improved the on_app_deploy function in server/apis/extenal.py for better readability and maintainability. This includes reorganizing conditional statements, modifying the structure of the run_env dictionary, and updating the app.volumes list.
• New Feature: Added configuration options for OpenAPI documentation URLs (openapi_url, docs_url, and redoc_url) in server/apis/restapi.py. This allows users to customize their API documentation endpoints.

[coderabbitai]

Walkthrough

This pull request includes a thoughtful refactoring of the on_app_deploy function for improved readability and maintainability, along with the addition of OpenAPI documentation URL parameters to the application instantiation in the REST API.

Changes

File Path	Summary
server/apis/extenal.py	Refactored on_app_deploy function for better structure and readability. Key changes include reorganized conditional statements, modified run_env dictionary structure, added streams list to run_env, and updated app.volumes with new volume configuration.
server/apis/restapi.py	Added three parameters (openapi_url, docs_url, redoc_url) to self.app instantiation for configuring OpenAPI documentation URLs.

🐇💻

"In the land of code where the shadows lie,

We refactor, enhance, under the cloudless sky.

With each pull request, we make our stand,

Crafting software with a careful hand.

So here's to changes, big and small,

In the end, they matter to us all."

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• Mention @coderabbitai in any review comment for bot assistance.
• Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

• Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
• Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
  resume reviews, enter @coderabbitai resume as any issue or review comment.

[coderabbitai]

Review Status

Actionable comments generated: 1

Details

Commits

Files that changed from the base of the PR and between 63183ab and 910e1d1.

Files selected for processing (2)

• server/apis/extenal.py (2 hunks)
• server/apis/restapi.py (1 hunks)

Files skipped from review due to trivial changes (1)

• server/apis/restapi.py

Additional comments (Suppressed): 3

server/apis/extenal.py (3)

• 23-26: The import of yaml is new in this hunk. Ensure that the PyYAML package is installed and properly managed in your project dependencies.

• 342-448: The logic for handling multiple streams has been refactored. The stream data is now stored in a list instead of a dictionary, which could affect how it's accessed elsewhere in the codebase. Also, the volume configuration for sparkrtconf has been updated to fix a file leakage issue. Make sure these changes are compatible with the rest of your application.

• 395-408: This block of code is responsible for updating the app.volumes list with a new volume configuration. It first removes any existing volume named sparkrtconf, then appends a new one with the updated configuration. This approach ensures that there is only one sparkrtconf volume in the list at any time, preventing potential duplication issues.