fix toDict issue of Literal null#22
Open
NITROGENousFish wants to merge 2 commits intoKronuz:masterfrom
Open
Conversation
@Kronuz By any chance you are considering this fix to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to store the AST to json using toDict() and re-translate it back to javascript with a npm package called escodegen . In the process I found an inconsistency between the parsing result of "null" and the esprima website (ssing 'value') , which causes the translation of AST back to javascript failed. I simply enhansed
visitor.pyAlso
del OCTAL_CONV, HEX_CONVincharacter.pywill cause an import issue when esprima-python is import relativly (not by pip install). I don't understand the meaning of removing these two global variables.