-
Notifications
You must be signed in to change notification settings - Fork 24
Build for osx-arm64 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5cf8b88 to
e8c79d2
Compare
e8c79d2 to
a5cc153
Compare
|
Good catch! |
|
Thanks! 😁 |
|
can we get a release for that? :) |
|
@Kromtec I see that you made a release, thanks for that! But somehow downloading the macos version still downloads 1.0 which still cannot run on arm macs :( am I doing something wrong?
|
|
I downloaded it over here and it seems to work? $ file /Applications/LegendsViewer.app/Contents/MacOS/LegendsViewer
/Applications/LegendsViewer.app/Contents/MacOS/LegendsViewer: Mach-O 64-bit executable arm64 |
|
The version 1.0 is hard-coded in some places, I guess some files could be turned into templates to automate that a bit |
|
For everything but MacOS the version comes only from the LegendsViewer.Backend.csproj file. I was not really aware of this extra file for MacOS that has the version number hardcoded to 1.0. As @vespakoen said, maybe in the future it is possible automate the version numbering more. When you open LegendsViewer it should show the correct version number in the top right corner. |
|
I see, thank you all! that's the thing, it immediately crashes, so since the filename was 1.0 and the version string was still 1.0 I assumed the release lets me download an old version. :/ but you are right it is the arm64 version: What I get though: |


Hoping it "just works" by changing x64 to arm64