Skip to content

Conversation

@vespakoen
Copy link
Contributor

Hoping it "just works" by changing x64 to arm64

@vespakoen
Copy link
Contributor Author

Good catch!
The arm64 version works fine on my M1 (arm64) macbook by the way ;)

@vespakoen vespakoen requested a review from Kromtec February 27, 2025 18:03
@Kromtec Kromtec changed the base branch from main to develop February 27, 2025 18:08
@Kromtec Kromtec merged commit af6e32e into Kromtec:develop Feb 27, 2025
1 check passed
@Kromtec
Copy link
Owner

Kromtec commented Feb 27, 2025

Thanks! 😁

@sharpner
Copy link

sharpner commented Apr 8, 2025

can we get a release for that? :)

@sharpner
Copy link

sharpner commented Apr 11, 2025

@Kromtec I see that you made a release, thanks for that! But somehow downloading the macos version still downloads 1.0 which still cannot run on arm macs :( am I doing something wrong?

image

@vespakoen
Copy link
Contributor Author

I downloaded it over here and it seems to work?

$ file /Applications/LegendsViewer.app/Contents/MacOS/LegendsViewer
/Applications/LegendsViewer.app/Contents/MacOS/LegendsViewer: Mach-O 64-bit executable arm64

@vespakoen
Copy link
Contributor Author

The version 1.0 is hard-coded in some places, I guess some files could be turned into templates to automate that a bit

@Kromtec
Copy link
Owner

Kromtec commented Apr 13, 2025

For everything but MacOS the version comes only from the LegendsViewer.Backend.csproj file. I was not really aware of this extra file for MacOS that has the version number hardcoded to 1.0. As @vespakoen said, maybe in the future it is possible automate the version numbering more.

When you open LegendsViewer it should show the correct version number in the top right corner.
image

@sharpner
Copy link

I see, thank you all!

that's the thing, it immediately crashes, so since the filename was 1.0 and the version string was still 1.0 I assumed the release lets me download an old version. :/ but you are right it is the arm64 version:

/Applications/LegendsViewer.app/Contents/MacOS/LegendsViewer: Mach-O 64-bit executable arm64

What I get though:

Failed to create CoreCLR, HRESULT: 0x80070008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants