Remove unnecessary backports dependency for recent python #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using importlib_metadata conditionally means for the majority of users on recent python, fewer dependencies need be installed, speeding up distro package managers as well as pip install and reducing bandwidth used. Using sys.version_info checks is self-documenting and various tools can autoremove it when dropping support for old versions of python. This reduces maintenance burden / tech debt when the codebase includes legacy hacks that are anyways slated to be eventually removed. Fixes: d1d02c6 Fixes: fc7d69c Bug: Kozea#545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using importlib_metadata conditionally means for the majority of users on recent python, fewer dependencies need be installed, speeding up distro package managers as well as pip install and reducing bandwidth used.
Using sys.version_info checks is self-documenting and various tools can autoremove it when dropping support for old versions of python. This reduces maintenance burden / tech debt when the codebase includes legacy hacks that are anyways slated to be eventually removed.
Fixes: d1d02c6
Fixes: fc7d69c
Bug: #545