Cape now bends alongside torso, and you can now bend limbs in Blockbench animations. #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I also optimized imports, that's why there are so many changed files... |
Owner
|
The optimize imports can break a lot of things, in future PRs, try to avoid doing that. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires my bendy-lib PR in order to work.
Related Emotecraft PR: KosmX/emotes#509
This PR isn't perfect, the bend still clips with the player if the bend value is large enough: https://cdn.discordapp.com/attachments/1293931136615190538/1318566662487932999/2024-12-17_16-41-37.mp4?ex=67661626&is=6764c4a6&hm=0d2ea42d86e3070cfca00c65db5efb49066fdd3b72240e97875bada646edc18a&
But it's much better than how it used to be.
I might look into fixing the issue in the video later but for now I think this PR is good enough, people usually don't bend the torso a full 90 degrees.
And of course being able to bend limbs in Blockbench is a feature that has been requested for a while now.
I also applied the my cape bug fixes to the elytra as well.