-
Notifications
You must be signed in to change notification settings - Fork 15
fix: check for request validator plugin in openAPI2kong cmd for path param schema #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 69.62% 69.73% +0.10%
==========================================
Files 24 24
Lines 2736 2739 +3
==========================================
+ Hits 1905 1910 +5
+ Misses 656 653 -3
- Partials 175 176 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@shivaygupta-dotcom LGTM, couple of things -
|
9548b32 to
a5bcc33
Compare
| @@ -0,0 +1,34 @@ | |||
| openapi: 3.0.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed since there are no path/operation parameters?
| @@ -0,0 +1,50 @@ | |||
| openapi: 3.0.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this file already covers both parameter at both path and operation levels, do we need additional individual tests for same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have discussed this offline. Please check and verify on this once.
| required: true | ||
| schema: | ||
| type: string | ||
| enum: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivaygupta-dotcom this is missing indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And leading to enum being missed in the expected file plugin schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed changes.
https://konghq.atlassian.net/browse/FTI-7191