Skip to content

Conversation

@shivaygupta-dotcom
Copy link
Contributor

@shivaygupta-dotcom shivaygupta-dotcom commented Jan 13, 2026

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2026

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.73%. Comparing base (8ac4652) to head (aa975b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   69.62%   69.73%   +0.10%     
==========================================
  Files          24       24              
  Lines        2736     2739       +3     
==========================================
+ Hits         1905     1910       +5     
+ Misses        656      653       -3     
- Partials      175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshadixit12
Copy link
Contributor

harshadixit12 commented Jan 19, 2026

@shivaygupta-dotcom LGTM, couple of things -

  1. There is some redundancy in the tests added, we don't need a test for path parameters not being there - this scenario would already be covered in existing tests
  2. PR description to be updated so anyone reviewing gets context.
  3. Commit messages to follow https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#commit-message-format

@shivaygupta-dotcom shivaygupta-dotcom changed the title fix: Added fix for Request Validator Plugin in openApi2kong cmd for a… fix: check for request validator plugin in openAPI2kong cmd for path param schema Jan 19, 2026
@@ -0,0 +1,34 @@
openapi: 3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed since there are no path/operation parameters?

@@ -0,0 +1,50 @@
openapi: 3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this file already covers both parameter at both path and operation levels, do we need additional individual tests for same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have discussed this offline. Please check and verify on this once.

required: true
schema:
type: string
enum:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivaygupta-dotcom this is missing indentation

Copy link
Contributor

@harshadixit12 harshadixit12 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And leading to enum being missed in the expected file plugin schema

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed changes.

@shivaygupta-dotcom shivaygupta-dotcom merged commit 17a3c38 into main Jan 22, 2026
5 checks passed
@shivaygupta-dotcom shivaygupta-dotcom deleted the fix/FTI-7191 branch January 22, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants