Skip to content

Conversation

@shivaygupta-dotcom
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2026

CLA assistant check
All committers have signed the CLA.

@harshadixit12
Copy link
Contributor

@shivaygupta-dotcom for future reference, let's follow the branch naming guidelines as well - this has dependency bump, so should be chore/xyz

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.78%. Comparing base (19a389c) to head (34f029d).

Files with missing lines Patch % Lines
tests/integration/test_utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
- Coverage   32.84%   32.78%   -0.06%     
==========================================
  Files          73       73              
  Lines        6556     6557       +1     
==========================================
- Hits         2153     2150       -3     
- Misses       4240     4243       +3     
- Partials      163      164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshadixit12
Copy link
Contributor

harshadixit12 commented Jan 23, 2026

@shivaygupta-dotcom regarding the code changes for linting errors -

  1. Why did the linter start erroring out now? Was there any recent version upgrade on CI with new rules?
  2. Why did we choose to make these code changes, and what impact will each change have?

@shivaygupta-dotcom shivaygupta-dotcom force-pushed the fix/go-apiops-version-bump branch from 2e50915 to 34f029d Compare January 27, 2026 06:11
@shivaygupta-dotcom
Copy link
Contributor Author

@shivaygupta-dotcom regarding the code changes for linting errors -

  1. Why did the linter start erroring out now? Was there any recent version upgrade on CI with new rules?
  2. Why did we choose to make these code changes, and what impact will each change have?
  1. With the new linter version(2.8.0) upgraded in CI, these issues started appearing. Based on my analysis, the newer version has stricter enforcement of the prealloc rule, which is now flagging cases that were previously allowed. but why after version upgrade is still not 100% sorted, I am checking on this and will update on this asap.
  2. We made these code changes to align the implementation with the linter’s recommendations. Instead of disabling the rule, we chose to update the code to follow best practices suggested by the linter. These changes improve code quality, readability, and performance predictability, while also ensuring long-term maintainability

@shivaygupta-dotcom shivaygupta-dotcom merged commit b6f3a09 into main Jan 27, 2026
38 of 40 checks passed
@shivaygupta-dotcom shivaygupta-dotcom deleted the fix/go-apiops-version-bump branch January 27, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants