Skip to content

Conversation

@ChrisF999
Copy link
Collaborator

@ChrisF999 ChrisF999 commented Jul 16, 2021

I made this super cool secret area can someone give it a look over and make sure its all right thanks xooo

theres also a really coool preview here https://koalabotuk.github.io/pr-for-we/

Copy link
Member

@Jamesflynn1 Jamesflynn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"swordf1sh" is a hard coded and visible password in the Javascript function
Solution: Add server side authentication calls.
Store usernames/passwords securely server side in a database

Can access /welcome.html directly
Solution: Ensure user authentication before accessing the page.

Can login without being a user
Solution: Require a username to be entered.

Can access "Other stuff that we don't want the world to have access to"
Solution: Display this page only if the authenticated user has the required (admin) role.

@Jaddison011 Jaddison011 self-requested a review July 16, 2021 13:15
Copy link

@Jaddison011 Jaddison011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue:
Password is hard coded into the website, leaving it exposed
Solution:
Use a secure database

Issue:
User doesn't have to be registered to log in
Solution:
Require a username with a respective password to log in

Issue:
Can bypass the login by accessing welcome.html
Solution:
Require a log in to access the page

Copy link

@cwsbowe cwsbowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can view the password "sword1sh" by inspecting the page. This can be addressed by using server-side authentication and storing user information in a secure database.

Does not require a username to log in, simply the password. Each user should have a unique username password combination stored in a database.

Can simply access the url /welcome.html which should require authentication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants