Grey team - Gilded Rose Task #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayDwee
reviewed
Jul 12, 2021
Member
JayDwee
left a comment
JayDwee
left a comment
There was a problem hiding this comment.
Worth looking into requirements.txt as a way to store what extra external libraries need installing through pip like pytest
Good removal of magic numbers in guilded_rose.py
docstrings should've been added to guilded_rose.py methods
Tests are good, short and clear (slight bonus points to green team though for removing 'magic' numbers in tests too, take a look at theirs for a hint)
All tests have a weird (but consistent) naming scheme. I'd suggest lowercase with underscores
Overall well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added initial set of tests.
Started on requirements for app.