clean warnings. Package build as url instead of string, readthedocs, Fixes #855, Fixes #864, Fixes #865, Fixes #866, #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarijo
reviewed
Dec 18, 2025
| REGEXP_READTHEDOCS_HTML = ( | ||
| r"<a\b[^>]+?href=['\"](https?://[^'\"\s]+?)['\"][^>]*?>" | ||
| r"(?:(?!</a>)[\s\S])*?" | ||
| r"<img\b[^>]+?src=['\"]https?://(?:readthedocs\.org/projects/|img\.shields\.io/pypi/)[^'\"\s]*" |
Collaborator
There was a problem hiding this comment.
This regular expression is potentially dangerous, and it may be slow.
Try this one instead:
r"""
<a\b
[^>]*\bhref=['"](https?://[^'"\s]+)['"]
[^>]*>
(?:
[^<]+
|
<(?!/a\b)[^>]*>
)*
<img\b
[^>]*\bsrc=['"]
https?://(?:readthedocs\.org/projects/|img\.shields\.io/pypi/)
[^'"\s>]+
['"]
"""
Contributor
Author
There was a problem hiding this comment.
ok, i'll try again after all test pass
dgarijo
reviewed
Dec 18, 2025
| self.assertTrue(len(package_results) > 0, "No package file info found") | ||
| self.assertEqual(package_results[0]["result"]["value"], "DESCRIPTION") | ||
| # self.assertEqual(package_results[0]["result"]["value"], "DESCRIPTION") | ||
| self.assertEqual(package_results[0]["result"]["value"], "https://example.org/DESCRIPTION") |
Collaborator
There was a problem hiding this comment.
why is this looking into example.org?
If somef is run locally and there is no repo, it should return the path to the file...
dgarijo
reviewed
Dec 18, 2025
| self.assertTrue(len(package_results) > 0, "No package file info found") | ||
| self.assertEqual(package_results[0]["result"]["value"], "bootstrap-datepicker-rails.gemspec") | ||
| # self.assertEqual(package_results[0]["result"]["value"], "bootstrap-datepicker-rails.gemspec") | ||
| self.assertEqual(package_results[0]["result"]["value"], "https://example.org/bootstrap-datepicker-rails.gemspec") |
dgarijo
reviewed
Dec 18, 2025
| self.assertTrue(len(package_results) > 0, "No package file info found") | ||
| self.assertEqual(package_results[0]["result"]["value"], "package.json") | ||
| # self.assertEqual(package_results[0]["result"]["value"], "package.json") | ||
| self.assertEqual(package_results[0]["result"]["value"], "http://example.com/package_neors.json") |
dgarijo
reviewed
Dec 18, 2025
| parse_toml_file(self.cargo_toml_path, result, "test") | ||
| # parse_toml_file(self.cargo_toml_path, result, "test") | ||
| print("self.cargo_toml_path:", self.cargo_toml_path) | ||
| parse_toml_file(self.cargo_toml_path, result, "http://example.com/rustdesk/Cargo.toml") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better readthedocs badges.