This repository was archived by the owner on Apr 19, 2023. It is now read-only.
App bugfixes: map overlay and review thumbs up/down#79
Open
App bugfixes: map overlay and review thumbs up/down#79
Conversation
sirhaug
reviewed
Nov 27, 2019
| export default ({ selectedVenue, showDetails }) => { | ||
| return ( | ||
| <ViewContainer opaque={true}> | ||
| <ViewContainer style={{ position: "absolute", bottom: 0, width: "100%" }} opaque={true}> |
Contributor
There was a problem hiding this comment.
Løste dette et problem, eller ble det lagt til som en "forsikring" mot at kartet flytter på seg?
Author
There was a problem hiding this comment.
Tru det eller ei, men det løste hele kartproblemet
sirhaug
reviewed
Nov 27, 2019
Comment on lines
+68
to
+69
| name={this.reviewIsPositive(review) ? "thumb-up" : "thumb-down"} | ||
| color={this.reviewIsPositive(review) ? colors.positiveColor : colors.negativeColor} |
sirhaug
reviewed
Nov 27, 2019
| }} | ||
| onPress={e => { | ||
| this.props.deselectVenue(); | ||
| this.removeMarkers(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the modal that appears when a venue is clicked into a map overlay, so that the map itself is not resized and crashes.
Made thumbs up and down in reviews render properly by checking for 1 and -1 instead of true and false.