Skip to content

Conversation

@Jo-Byr
Copy link
Collaborator

@Jo-Byr Jo-Byr commented Jan 19, 2026

Add Erase/Fill x Inside/Outside parametrization
Add Unlimited, Positive, Negative, Symmetric parametrization

Add Erase/Fill x Inside/Outside parametrization
Add Unlimited, Positive, Negative, Symmetric parametrization
@Jo-Byr Jo-Byr self-assigned this Jan 19, 2026
@Jo-Byr Jo-Byr marked this pull request as draft January 19, 2026 14:34
@Jo-Byr
Copy link
Collaborator Author

Jo-Byr commented Jan 19, 2026

@Thibault-Pelletier everything should be working as it is in 3D Slicer, except the symmetric option for which the actual distance in the volume is not the one requested in the UI.

I suspect this is due to a reference issue, where the Xmm defined in the UI should end up as the value in the RAS reference, but I apply it in the Slice reference ? If this is the case, should I use view_node.GetSliceToRAS().Invert() to compute the good distance ? But then I was not sure it would work correctly for non axis-aligned applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants