feat: add a Dockerfile #23
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you please add a non WSL dockerfile ? Related to: #17 |
bourdaisj
reviewed
Sep 2, 2025
| @@ -0,0 +1,26 @@ | |||
| FROM python:3.10-slim | |||
There was a problem hiding this comment.
why 3.10 and not a more recent version?
Collaborator
There was a problem hiding this comment.
trame-slicer is currently limited to 3.10 because of the available vtk MRML wheels.
bourdaisj
reviewed
Sep 2, 2025
docker/README
Outdated
Comment on lines
11
to
17
| - To use EGL: | ||
|
|
||
| `docker run -p 8080:8080 -it --gpus all -e VTK_DEFAULT_OPENGL_WINDOW=vtkEGLRenderWindow -e LD_LIBRARY_PATH=/usr/lib/wsl/lib -v /usr/lib/wsl:/usr/lib/wsl trame-slicer-wsl` | ||
|
|
||
| - To use X server: | ||
|
|
||
| `docker run -p 8080:8080 -it --gpus all -e DISPLAY -e LD_LIBRARY_PATH=/usr/lib/wsl/lib -v /usr/lib/wsl:/usr/lib/wsl -v /tmp/.X11-unix:/tmp/.X11-unix trame-slicer-wsl` |
There was a problem hiding this comment.
probably missing some host requirements here, I can't get it to work on my windows 10 WSL. It's always using llvmpipe. I have nvidia drivers installed and able to use my GPU inside WSL.
Collaborator
|
Thx for the PR! Regarding the PR, could you amend the commit to replace feat by doc as we don't want to trigger a new minor release for this dockerfile? 🙏 |
Thibault-Pelletier
force-pushed
the
main
branch
3 times, most recently
from
7060d84 to
86fd515
Compare
Thibault-Pelletier
force-pushed
the
main
branch
2 times, most recently
from
e94ad01 to
b07b3d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.