Skip to content

Conversation

@finetjul
Copy link
Member

This does not work yet:

  • trame expects the second element from the module to be a dict and not a string

This is not perfect:

  • how other modules (e.g. trame-gwc) are supposed to add their own config (e.g. icon aliases) without overwriting the one (e.g. themes) passed as parameter?

@finetjul finetjul requested a review from jourdain November 21, 2024 08:46
@finetjul finetjul changed the title DRAFT feat(vuetify2): set vuetify config from VAppLayout feat(vuetify2): set vuetify config from VAppLayout Nov 21, 2024
scripts = ["__trame_vuetify/trame-vuetify.umd.min.js"]
styles = ["__trame_vuetify/trame-vuetify.css"]
vue_use = ["trame_vuetify"]
vue_use = [("trame_vuetify", "trame.state.get('trame__vuetify2_config')||{}")]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trame expects the second tuple argument to be a dict and not a string. how can I do that @jourdain ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in v2 the right side does not get evaluated. Also with vuetify2, it is easier to patch the $vuetify variable on the JS side after loading. So you can do it inside you JS library directly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the trame app level (trame-client) as the new (v3) implementation is slightly different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants