Remove js-lib and refactor vue-components to use @kitware/vtk-wasm #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jspanchu
commented
Aug 12, 2025
jspanchu
commented
- Depends on Add npm package vtk-wasm#14
- Deleted js-lib directory including package.json, vite configuration files, and related build scripts.
- Updated vue-components package.json to include @kitware/vtk-wasm as a dependency.
- Refactored VtkLocal component to import RemoteSession from @kitware/vtk-wasm.
- Removed remote.js, standalone.js, viewer.js, wasmLoader.js, style.css from vue-components.
- Updated viewer.js to remove ExportViewer class and related functionality.
jourdain
reviewed
Aug 12, 2025
jourdain
reviewed
Aug 12, 2025
jourdain
reviewed
Aug 12, 2025
Collaborator
|
Change seems reasonable. We just need to test it once the package is published. |
jspanchu
force-pushed
the
use-vtk-wasm-npm
branch
from
d9b4c7a to
9a2b6e9
Compare
Member
Author
|
I published to my namespace in https://www.npmjs.com/package/@jspanchu/vtk-wasm?activeTab=readme and tested that in trame-vtklocal by replacing kitware with jspanchu. It worked. |
jspanchu
force-pushed
the
use-vtk-wasm-npm
branch
from
9a2b6e9 to
ded6bcd
Compare
- Deleted js-lib directory including package.json, vite configuration files, and related build scripts. - Updated vue-components package.json to include @kitware/vtk-wasm as a dependency. - Refactored VtkLocal component to import RemoteSession from @kitware/vtk-wasm. - Removed remote.js, standalone.js, viewer.js, wasmLoader.js, style.css from vue-components. - Updated viewer.js to remove ExportViewer class and related functionality.
jspanchu
force-pushed
the
use-vtk-wasm-npm
branch
from
ded6bcd to
0545876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.