-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add WebXR Helper widget #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You need to update the version of vue-vtk-js in that PR https://github.com/Kitware/trame-vtk/blob/master/.fetch_externals.sh |
d5a8fa9 to
16d52a4
Compare
finetjul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand how it knows on which view the helper applies...
|
The helper has a vtkView (or a vtkLocalView) as its parent. It can get the corresponding ClientView (or LocalView) thanks to the Vue.js provide/inject mechanism. For instance, the vtkView Vue component is providing the ClientView object here |
|
It would be nice to add an example in this repo showcasing the usage of XR |
|
I added an example, let me know if I need to change anything. |
|
@jourdain do you think tests failures are related to this change or is the CI unstable ? |
|
CI is unstable for remote rendering of volume rendering. (slow and image capture happen before the resized image is retrieved) We may have to disable that test or figure out a way to wait longer before doing image comparison of the browser. |
937543a to
9a08db3
Compare
|
Is the CI missing a |
|
yes that was the solution for trame-vtklocal |
|
I can't find a way to fix the CI. @jourdain do you have any idea ? |
|
We need to update the CI to do what I recently did in trame-tauri |
|
The failing CI is due to an issue with Selenium. We are switching over to Playwright soon where the issue will be resolved. |
|
@munozco if you rebase on master, it should fix your CI issues. |
4f4fdab to
11fadb4
Compare
|
Are the tests working for you locally? |
|
No, they are not working locally. The big int test is having a Also, on my machine, 3 tests on master are failing (big int, lookup table and volume rendering) because output image doesn't match with any of the baselines. They are failing for a few pixels. |
|
Can you double check that "older" vtk.js version work and that is indeed a regression? |
|
I checked with older and newer vtk.js versions, and with both versions the "BigInt" test works. So this looks like I should bump vtk.js in vue-vtk-js. What do you think ? |
|
A bump of vtk.js could indeed be good for vue-vtk-js. The strange thing is that this test was working before. So I'm not sure why changed. |
|
Sorry, I mixed things up. This doesn't work using newer vtk.js versions. |
|
Here is the answer the latest code, don't have that piece anymore. |



This adds a WebXR Helper widget to enable
VtkViewandVtkLocalViewto be used for a WebXR session.vue-vtk-js PR: Kitware/vue-vtk-js#9
The new
VtkWebXRHelperclass contains theXrSessionTypesenum that has the same values as XrSessionTypes in vtk.js.Here's an example that uses the new
VtkWebXRHelperwidget in a TrameApp: