-
Notifications
You must be signed in to change notification settings - Fork 3
Adding tauri bundling example for ParaView app #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jourdain Can you take a look? I had to skip windows as I have no way to test it. |
de2521d to
dc5211b
Compare
|
You are missing the splash screen in |
|
Windows is trickier as the sidecar is an actual executable that needs to be compiled. |
|
otherwise it looks good. I haven't tested it though... |
bd36dea to
2fe6936
Compare
| --name server --hidden-import pkgutil \ | ||
| --collect-data trame_vtk \ | ||
| --collect-data trame_client \ | ||
| --collect-data trame_vuetify \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--collect-data on trame_* is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only if you don't use http for web delivery. Either way, you should not do http delivery.
| rootdir=`dirname $0` | ||
| rootdir=`cd $rootdir && cd .. && pwd` | ||
|
|
||
| $rootdir/Resources/server/server $@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing std caching option
| rootdir=`dirname $0` | ||
| rootdir=`cd $rootdir && cd .. && pwd` | ||
|
|
||
| $rootdir/Resources/server/server $@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing std caching option
| rootdir=`dirname $0` | ||
| rootdir=`cd $rootdir && cd ../lib/cone && pwd` | ||
|
|
||
| $rootdir/server/server $@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing std caching option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed as it would not work
52515bb to
33584f4
Compare
|
@jourdain updated and tested -- this is the same approach I use for QuickView. |
| # receives the port number before Python's stdout buffer flushes | ||
| @life_cycle.server_ready | ||
| def _tauri_ready(self, **_): | ||
| os.write(1, f"tauri-server-port={self.server.port}\n".encode()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's how you prevent ParaView buffering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! os.write very eagerly writes to stdcout, so we don't have to wait around for ParaView to flush. -- This still only prints the two lines that we have in the calls. ParaView still works on a separate buffer and flushes later. So we might see prints happening not in chronological order.
|
You should fix your commit message. Something like |
Adding example for bundling an app that uses ParaView. To bundle paraview properly it's important to execute PyInstaller with the option `--collect-all` for ParaView. `os.write` for writing out information tauri requires. Also a custom call RemotingCore to force offscreen rendering.
17e8698 to
aab718e
Compare
Adding example for bundling an app that uses ParaView.
The usual approach does not play well with ParaView with a lot of complains
about missing dynamic libraries. Using
pvpythonsolves these issues.