fix(utils): do not import vtk unnecessarily #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Justineantoine
force-pushed
the
fix_unwanted_vtk_import
branch
from
5e631f4 to
671901e
Compare
Justineantoine
force-pushed
the
fix_unwanted_vtk_import
branch
from
671901e to
cc24899
Compare
Contributor
|
@Justineantoine after Alexy's investigation, crash with VTK 9.5 can be fixed by adding @jourdain Should this fix be a separate commit or do we integrate that in Justine's PR? |
Collaborator
|
could be in same pr.. Just maybe a commit in itself for clarity. Change logs and releases rely on commits not pr. |
Justineantoine
force-pushed
the
fix_unwanted_vtk_import
branch
from
cc24899 to
dba8237
Compare
Member
|
@Justineantoine can it be merged ? |
Collaborator
|
Should I merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As vtk is not in the project dependencies, a
ModuleNotFoundErroronvtkmodulesis generated when theutilsare imported even if vtk is an optional dependencyThe AbstractWindow is now a Protocol and the VtkWindow is in its own vtk_utils which is optionally imported if vtk has been installed.
No breaking change.