fix(RawImageDisplayArea): add user_data echo when frame received #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hum, can we talk? I see the idea, but I don't like the naming and how things are done. We can achieve more with less. |
…ame received When a frame is sent by the server to the RawImageDisplayArea, allow the inclusion of `ack_id` in the meta information, which is sent as message back to the server when the frame is received. Allows the server to track if the client is keeping up with the frames sent. Also allow `user_data` in the meta information, which is propagated to the client as a Vue event.
aronhelser
force-pushed
the
rida_user_data
branch
from
00c408c to
29c66cb
Compare
Author
|
Updated to |
Collaborator
|
Missing event listing in Python classes (i.e.: RemoteControlledArea). |
jourdain
reviewed
Jul 5, 2024
| } | ||
| // if the frame sender provide user_data, emit as a client event | ||
| if (meta['user_data'] !== undefined) { | ||
| this.$emit('user_data', meta['user_data']); |
Collaborator
There was a problem hiding this comment.
this.$emit('user-data', meta.user_data);
jourdain
reviewed
Jul 5, 2024
| ctx.putImageData(imageData, 0, 0); | ||
| // if the frame sender provided an ack_id, send back to the server | ||
| // so they know this frame has been processed | ||
| if (meta['ack_id'] !== undefined) { |
Collaborator
There was a problem hiding this comment.
meta.ack_id !== undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a frame is sent by the server to the RawImageDisplayArea, allow the inclusion of
user_datain the meta information, which is sent as message back to the server when the frame is received. Allows the server to track if the client is keeping up with the frames sent.