fix(explorers): Remove code redundancy #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
Jul 21, 2025
| ], | ||
| type="number", | ||
| ) | ||
| ScalingControls().create() |
jourdain
reviewed
Jul 21, 2025
| click=(update_rendering, "[true]"), | ||
| ) | ||
|
|
||
| UpdateButton(update_rendering).create() |
jourdain
reviewed
Jul 21, 2025
| ) | ||
| # Axis slicing controls | ||
| axis_controls = AxisSlicingControls() | ||
| for _component in axis_controls.create(): |
Collaborator
There was a problem hiding this comment.
not sure you need the for loop. Also I don't get the .create() call...
jourdain
reviewed
Jul 21, 2025
| type="number", | ||
| ) | ||
| # Slice stepping controls | ||
| SliceSteppingControls().create() |
jourdain
reviewed
Jul 21, 2025
| ) | ||
| # Axis slicing controls | ||
| axis_controls = AxisSlicingControls() | ||
| for _component in axis_controls.create(): |
jourdain
reviewed
Jul 21, 2025
| type="number", | ||
| ) | ||
| # Slice stepping controls | ||
| SliceSteppingControls().create() |
jourdain
reviewed
Jul 21, 2025
| ], | ||
| type="number", | ||
| ) | ||
| ScalingControls().create() |
jourdain
reviewed
Jul 21, 2025
| click=(update_rendering, "[true]"), | ||
| ) | ||
|
|
||
| UpdateButton(update_rendering).create() |
jourdain
reviewed
Jul 21, 2025
| self.max_time_width = max_time_width | ||
| self.max_time_index_width = max_time_index_width | ||
|
|
||
| def create(self): |
Collaborator
There was a problem hiding this comment.
why do you need a create() method?
jourdain
reviewed
Jul 21, 2025
| self.scale_y = scale_y | ||
| self.scale_z = scale_z | ||
|
|
||
| def create(self): |
jourdain
reviewed
Jul 21, 2025
| self.data_arrays = data_arrays | ||
| self.dirty_data = dirty_data | ||
|
|
||
| def create(self): |
jourdain
reviewed
Jul 21, 2025
| self.dataset_bounds = dataset_bounds | ||
| self.axis_lower = axis.lower() | ||
|
|
||
| def create(self): |
jourdain
reviewed
Jul 21, 2025
| for i, axis in enumerate(XYZ) | ||
| ] | ||
|
|
||
| def create(self): |
jourdain
reviewed
Jul 21, 2025
| def __init__(self, axis_names="axis_names"): | ||
| self.axis_names = axis_names | ||
|
|
||
| def create(self): |
jourdain
reviewed
Jul 21, 2025
| ], | ||
| type="number", | ||
| ) | ||
| ScalingControls().create() |
jourdain
reviewed
Jul 21, 2025
| click=(update_rendering, "[true]"), | ||
| ) | ||
|
|
||
| UpdateButton(update_rendering).create() |
Collaborator
|
Looks good except that I don't understand the split between the constructor and the create method? Is the constructor supposed to already create the object/ui? |
Collaborator
Author
|
Closing this as these changes are redundant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.