Skip to content

Conversation

@stephencrowell
Copy link
Collaborator

No description provided.

pyproject.toml Outdated
[project]
name="nrtk-explorer"
version="0.6.0"
version="0.7.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not change the version. The CI will do it for you.

Copy link
Collaborator

@brianhhu brianhhu Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue was that this somehow was not done automatically with the last release? We should be on v0.7.0, but somehow the pyproject.toml is still stuck on 0.6.0?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, for the CI to cut a release, you will need to:

  1. merge master to release
  2. wait for CI to create release with new commit (changelog update and so on)
  3. merge release to master

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue was that this somehow was not done automatically with the last release? We should be on v0.7.0, but somehow the pyproject.toml is still stuck on 0.6.0?

Then we could be missing "merge release back to master"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped the change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need to update the semantic-release github action version.
Maybe merging the dependabot MR could solve the issue.

But we should make sure that release has been merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants