Fix polygon interaction bugs #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Suppress hover/context menu for existing annotations when actively placing a new polygon or rectangle - Add cross-tool awareness between polygon and rectangle tools - Check getActiveWidget() in widget behaviors to defer to focused widget - Ensure grabFocus properly sets hasFocus to maintain activeState
…ther When placing a new polygon inside an existing one: - Right-click to remove points now works correctly - Old polygon handles no longer show on hover - Tooltip doesn't appear for containing polygon after placing finishes Key changes: - Check getPlacing() before activeState in handleRightButtonPress - Check if any other widget has focus before handling events - Properly release focus when polygon finishes placing - Hide handles on finished polygons when another is placing with points
PaulHax
changed the title
- Prevent hover handles on existing polygons while placing new one - Allow right-click to remove points when placing inside other annotations - Clear stale activeState on all widgets when placing polygon loses focus - Add hasFocus check to RulerWidget (used by RectangleWidget)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan