Skip to content

General slicing #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayenpure merged 6 commits into from
Dec 8, 2025
Merged

General slicing #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
552fbd9
feat: adding partial changes for supporing general ESM reader
ayenpure Nov 17, 2025
f496510
fix: Add/fix dynamic dimensions sliders
ayenpure Dec 3, 2025
c6242fb
fix: Fixing slicing based on arbitrary dimensions
ayenpure Dec 4, 2025
87c3d56
fix: Remove unnecessary print statements
ayenpure Dec 4, 2025
3fbd8fc
fix: fixing errors while variable groupings
ayenpure Dec 5, 2025
0de0666
fix : Adding UI fixes for arbitrary dimension selections
ayenpure Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 81 additions & 48 deletions src/e3sm_quickview/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from e3sm_quickview.assets import ASSETS
from e3sm_quickview.components import doc, file_browser, css, toolbars, dialogs, drawers
from e3sm_quickview.pipeline import EAMVisSource
from e3sm_quickview.utils import compute, js, constants, cli
from e3sm_quickview.utils import compute, cli
from e3sm_quickview.view_manager import ViewManager


Expand Down Expand Up @@ -45,13 +45,11 @@ def __init__(self, server=None):
"variables_selected": [],
# Control 'Load Variables' button availability
"variables_loaded": False,
# Level controls
"midpoint_idx": 0,
# Dynamic type-color mapping (populated when data loads)
"variable_types": [],
# Dimension arrays (will be populated dynamically)
"midpoints": [],
"interface_idx": 0,
"interfaces": [],
# Time controls
"time_idx": 0,
"timestamps": [],
# Fields summaries
"fields_avgs": {},
Expand Down Expand Up @@ -208,18 +206,19 @@ def _build_ui(self, **_):

@property
def selected_variables(self):
vars_per_type = {n: [] for n in "smi"}
from collections import defaultdict

vars_per_type = defaultdict(list)
for var in self.state.variables_selected:
type = var[0]
name = var[1:]
vars_per_type[type].append(name)
type = self.source.varmeta[var].dimensions
vars_per_type[type].append(var)

return vars_per_type
return dict(vars_per_type)

@property
def selected_variable_names(self):
# Remove var type (first char)
return [var[1:] for var in self.state.variables_selected]
return [var for var in self.state.variables_selected]

# -------------------------------------------------------------------------
# Methods connected to UI
Expand Down Expand Up @@ -369,30 +368,42 @@ async def data_loading_open(self, simulation, connectivity):
self.state.variables_filter = ""
self.state.variables_listing = [
*(
{"name": name, "type": "surface", "id": f"s{name}"}
for name in self.source.surface_vars
),
*(
{"name": name, "type": "interface", "id": f"i{name}"}
for name in self.source.interface_vars
),
*(
{"name": name, "type": "midpoint", "id": f"m{name}"}
for name in self.source.midpoint_vars
{
"name": var.name,
"type": str(var.dimensions),
"id": f"{var.name}",
}
for _, var in self.source.varmeta.items()
),
]

# Build dynamic type-color mapping
from e3sm_quickview.utils.colors import get_type_color

dim_types = sorted(
set(str(var.dimensions) for var in self.source.varmeta.values())
)
self.state.variable_types = [
{"name": t, "color": get_type_color(i)}
for i, t in enumerate(dim_types)
]

# Update Layer/Time values and ui layout
n_cols = 0
available_tracks = []
for name in ["midpoints", "interfaces", "timestamps"]:
values = getattr(self.source, name)
self.state[name] = values

if len(values) > 1:
for name, dim in self.source.dimmeta.items():
values = dim.data
# Convert to list for JSON serialization
self.state[name] = (
values.tolist()
if hasattr(values, "tolist")
else list(values)
if values is not None
else []
)
if values is not None and len(values) > 1:
n_cols += 1
available_tracks.append(constants.TRACK_ENTRIES[name])

available_tracks.append({"title": name, "value": name})
self.state.toolbar_slider_cols = 12 / n_cols if n_cols else 12
self.state.animation_tracks = available_tracks
self.state.animation_track = (
Expand All @@ -401,6 +412,20 @@ async def data_loading_open(self, simulation, connectivity):
else None
)

from functools import partial

# Initialize dynamic index variables for each dimension
for track in available_tracks:
dim_name = track["value"]
index_var = f"{dim_name}_idx"
if "time" in index_var:
self.state[index_var] = 50
else:
self.state[index_var] = 0
self.state.change(index_var)(
partial(self._on_slicing_change, dim_name, index_var)
)

@controller.set("file_selection_cancel")
def data_loading_hide(self):
self.state.active_tools = [
Expand All @@ -414,11 +439,10 @@ async def _data_load_variables(self):
"""Called at 'Load Variables' button click"""
vars_to_show = self.selected_variables

self.source.LoadVariables(
vars_to_show["s"], # surfaces
vars_to_show["m"], # midpoints
vars_to_show["i"], # interfaces
)
# Flatten the list of lists
flattened_vars = [var for var_list in vars_to_show.values() for var in var_list]

self.source.LoadVariables(flattened_vars)

# Trigger source update + compute avg
with self.state:
Expand Down Expand Up @@ -455,30 +479,42 @@ async def _on_projection(self, projection, **_):
await asyncio.sleep(0.1)
self.view_manager.reset_camera()

@change("active_tools")
@change("active_tools", "animation_tracks")
def _on_toolbar_change(self, active_tools, **_):
top_padding = 0
for name in active_tools:
top_padding += toolbars.SIZES.get(name, 0)
if name == "select-slice-time":
track_count = len(self.state.animation_tracks or [])
rows_needed = max(1, (track_count + 2) // 3) # 3 sliders per row
top_padding += 70 * rows_needed
else:
top_padding += toolbars.SIZES.get(name, 0)

self.state.top_padding = top_padding

def _on_slicing_change(self, var, ind_var, **_):
self.source.UpdateSlicing(var, self.state[ind_var])
self.source.UpdatePipeline()

self.view_manager.update_color_range()
self.view_manager.render()

# Update avg computation
# Get area variable to calculate weighted average
data = self.source.views["atmosphere_data"]
self.state.fields_avgs = compute.extract_avgs(
data, self.selected_variable_names
)

@change(
"variables_loaded",
"time_idx",
"midpoint_idx",
"interface_idx",
"crop_longitude",
"crop_latitude",
"projection",
)
def _on_time_change(
def _on_downstream_change(
self,
variables_loaded,
time_idx,
timestamps,
midpoint_idx,
interface_idx,
crop_longitude,
crop_latitude,
projection,
Expand All @@ -487,12 +523,9 @@ def _on_time_change(
if not variables_loaded:
return

time_value = timestamps[time_idx] if len(timestamps) else 0.0
self.source.UpdateLev(midpoint_idx, interface_idx)
self.source.ApplyClipping(crop_longitude, crop_latitude)
self.source.UpdateProjection(projection[0])
self.source.UpdateTimeStep(time_idx)
self.source.UpdatePipeline(time_value)
self.source.UpdatePipeline()

self.view_manager.update_color_range()
self.view_manager.render()
Expand Down
34 changes: 20 additions & 14 deletions src/e3sm_quickview/components/drawers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,20 +68,26 @@ def __init__(self, load_variables=None):

with self:
with html.Div(style="position:fixed;top:0;width: 500px;"):
with v3.VCardActions(key="variables_selected.length"):
for name, color in [
("surfaces", "success"),
("interfaces", "info"),
("midpoints", "warning"),
]:
v3.VChip(
js.var_title(name),
color=color,
v_show=js.var_count(name),
size="small",
closable=True,
click_close=js.var_remove(name),
)
with v3.VCardActions(
key="variables_selected.length",
classes="flex-wrap",
style="overflow-y: auto; max-height: 100px;",
):
v3.VChip(
"{{ variables_selected.filter(id => variables_listing.find(v => v.id === id)?.type === vtype.name).length }} {{ vtype.name }}",
v_for="(vtype, idx) in variable_types",
key="idx",
color=("vtype.color",),
v_show=(
"variables_selected.filter(id => variables_listing.find(v => v.id === id)?.type === vtype.name).length",
),
size="small",
closable=True,
click_close=(
"variables_selected = variables_selected.filter(id => variables_listing.find(v => v.id === id)?.type !== vtype.name)",
),
classes="ma-1",
)

v3.VSpacer()
v3.VBtn(
Expand Down
Loading
Loading