Fixed race condition in OutOfProcessQueue #66#67
Open
Kittyfisto wants to merge 1 commit intorelease/0.5.166from
Open
Fixed race condition in OutOfProcessQueue #66#67Kittyfisto wants to merge 1 commit intorelease/0.5.166from
Kittyfisto wants to merge 1 commit intorelease/0.5.166from
Conversation
The child process was able to survive a call to Dispose() if it crashed right before Dispose() was called. OutOfProcessQueue.Dispose() now performs synchronisation at the cost of of a slightly changed behaviour visible to users, if they call dispose from within a FailureHandler callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The child process was able to survive a call to Dispose() if it crashed right before Dispose() was called.
OutOfProcessQueue.Dispose() now performs synchronisation at the cost of of a slightly changed behaviour visible to users, if they call dispose from within a FailureHandler callback:
Prior to this bugfix, Dispose() did not block (which caused this behavior in the first place), however users calling Dispose() from within the FailureHandler did not see any delays: Dispose() returned immediately.
Now Dispose() blocks until the worker thread is stopped, however since the worker thread executes the failure handler, we this would cause a deadlock. Dispose() circumnavigates this by waiting for a maximum of 5 seconds and the continuing nevertheless.
However, in the end, calling Dispose() from within a callback is very strongly discouraged nevertheless.