Unconstrained triangle sketch failing to converge#238
Unconstrained triangle sketch failing to converge#238adamchalmers wants to merge 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 90.37% 90.52% +0.15%
==========================================
Files 23 23
Lines 5215 5215
==========================================
+ Hits 4713 4721 +8
+ Misses 502 494 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0deeeed to
b4581e9
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
| (3, 13.16), | ||
| (4, -11.5), | ||
| (5, 10.93), | ||
| (6, -68.72), |
There was a problem hiding this comment.
Changing the -68 to a -28 makes this test case converge. I think this shows a problem with one of our constraints stability, I think it should be reasonable to find convergence here.
No description provided.