Skip to content

Unconstrained triangle sketch failing to converge#238

Draft
adamchalmers wants to merge 2 commits intomainfrom
achalmers/triangle-size-unsolved
Draft

Unconstrained triangle sketch failing to converge#238
adamchalmers wants to merge 2 commits intomainfrom
achalmers/triangle-size-unsolved

Conversation

@adamchalmers
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.52%. Comparing base (179b737) to head (b4581e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   90.37%   90.52%   +0.15%     
==========================================
  Files          23       23              
  Lines        5215     5215              
==========================================
+ Hits         4713     4721       +8     
+ Misses        502      494       -8     
Flag Coverage Δ
unittests 90.52% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamchalmers adamchalmers force-pushed the achalmers/triangle-size-unsolved branch from 0deeeed to b4581e9 Compare March 31, 2026 20:28
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 31, 2026

Merging this PR will not alter performance

✅ 8 untouched benchmarks
⏩ 16 skipped benchmarks1


Comparing achalmers/triangle-size-unsolved (3cbf5f4) with main (179b737)

Open in CodSpeed

Footnotes

  1. 16 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

(3, 13.16),
(4, -11.5),
(5, 10.93),
(6, -68.72),
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the -68 to a -28 makes this test case converge. I think this shows a problem with one of our constraints stability, I think it should be reasonable to find convergence here.

@adamchalmers adamchalmers changed the title Add a unit test for a strange KCL failure Unconstrained triangle sketch failing to converge Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant