Open
Conversation
This test was too specific; it was looking for one exact solution, but because the system was underconstrained, the solver could have many possible valid solutions.
Inconsistent systems will never have a global residual near zero; but they'll have a _minimum_ in the residual, and we should detect and return that state.
CodSpeed Performance ReportMerging #157 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## achalmers/new-solver #157 +/- ##
========================================================
- Coverage 93.25% 93.23% -0.03%
========================================================
Files 17 17
Lines 3738 3770 +32
========================================================
+ Hits 3486 3515 +29
- Misses 252 255 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamchalmers
force-pushed
the
achalmers/new-solver
branch
from
3a2b4d8 to
46aaa5d
Compare
adamchalmers
force-pushed
the
achalmers/new-solver
branch
from
46aaa5d to
4bf27cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.