-
Notifications
You must be signed in to change notification settings - Fork 23
Speciation calculations in new wrapper #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n preparation for speciation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 85.69% 85.68% -0.01%
==========================================
Files 10 10
Lines 1608 1607 -1
Branches 285 285
==========================================
- Hits 1378 1377 -1
Misses 194 194
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…roperties (osmotic coefficient)
…ing to test_phreeqc.py
|
@rkingsbury - if the tests pass, then this is ready to merge from my end. It shouldn't affect anything on user's side of things since the default engine hasn't been changed, and all imports of The version of the wrapper package This should give us a chance to test the release workflow. |
rkingsbury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vineet! I'm ready to merge pending these small edits.
…ass; DeprecationWarning on any use of the native engine
WIP to have
PyEQLEOSsupport all methods currently supported by thePhreeqcEOSengine.