Adding a space after periods messes with (text:1.1) syntax#5
Open
Hapseleg wants to merge 13 commits intoKinglord:mainfrom
Open
Adding a space after periods messes with (text:1.1) syntax#5Hapseleg wants to merge 13 commits intoKinglord:mainfrom
Hapseleg wants to merge 13 commits intoKinglord:mainfrom
Conversation
idrirap
reviewed
Nov 11, 2024
web/prompt_gallery.js
Outdated
| return existing + ', ' + newText; | ||
| } | ||
|
|
||
| return existing + newText; |
There was a problem hiding this comment.
I agree, cleaning the existing text can break the entire prompt. I hope this gets merged :)
If the original issue was to be sure to have a comma separating to new tags from the existing tags, maybe a fix can be:
Suggested change
| return existing + newText; | |
| return existing.split(",").concat(newText.split(",")).join(","); |
Owner
|
Thanks for submitting these, I've been working hard on the lora sidebar trying to get it into a good place and I'm almost there, I'll try to give these changes a review here in a day or two and merge things up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding a space after period messes with weighting syntax (mouse:1.1) turns into (mouse:1. 1) which invalidates it