Fix Windows builds of #247 #249
Conversation
…s builds do not break at the install step from bash interpreting the backslashes as escape characters.
Use single quotes around workspace path inside actions so that windows builds do not break at the install step from bash interpreting the backslashes as escape characters.
adakite1
force-pushed
the
artifacts
branch
3 times, most recently
from
9707ac1 to
fc6f70c
Compare
|
Awesome, thanks a lot for picking that up! Looks great, just one question: Was the static linking on Ubuntu and macOS caused by some build failures? |
|
!! Sorry I was just working on those after fixing the windows build but I didn't realize it automatically picked my changes there too haha, I was going to open another pull request for generating macOS universal binaries and also statically linking the linux binaries because when I tried to run the binaries on WSL2 it gave me an error that the libc and co versions were not supported. Let me reverse those for this pr. |
|
Artifacts not tagged as releases get deleted by Github after 90 days and I've run into situations where projects that depend on it for downloads have their downloads become inaccessible after some time, so I've also set up a system of quickly generating a release for armips from tag pushes, this is sort of how it looks like: https://github.com/adakite1/_armips_automated_and_tagged_builds/releases By default it sets it to a pre-release (can be changed manually later), uploads the artifacts, and names the release based on the same scheme as the artifact filenames. It also retains builds on push and pull_request. I could also make a pull request for that if you'd like it too? |
|
Hm... that sounds like a good idea to replace the buildbot, yeah! I think it's definitely worth adding. Thanks! |
|
Gotcha, I'll open the prs then ;) |
2 participants
This PR is based off of #247 and fixes the issue of Windows builds breaking at the Install step.
The backward slashes inside
${{github.workspace}}are interpreted as escape characters by bash, but it appears it can be fixed (according to https://stackoverflow.com/questions/66450348/need-to-convert-back-slashes-to-forward-slashes-in-github-action-work-flow) by single quoting uses of that variable, and this only needs to be done where bash is used over the default.