Bugfixes and Quality of Life pass#39
Merged
Crystalwarrior merged 5 commits intomasterfrom Nov 16, 2025
Merged
Conversation
Use current dropdown position instead of last message position for area transition Fix crash if LIST_REASON is sent before courtroom is constructed Send ~stop.mp3 instead of "" when triggering "stop music" packet Do not reset sfx and anim when swapping between emotes. However, sfx is still dependent on preanim which shouldn't be happening
Fix position dropdown forcing the character's default position, even if it's not actually available to us in our dropdown Fix crash if get_current_position is called before ActorData exists
…ort open for preanim-enabled characters rather than just idle sprite ones This means if you select a SFX, your preanim setting remains untouched. Internally, having a custom SFX still enables preanim, so this is fully compatible with older clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use current dropdown position instead of last message position for area transition
Fix crash if LIST_REASON is sent before courtroom is constructed
Send ~stop.mp3 instead of "" when triggering "stop music" packet
Make player status tooltip appear as fast as it can when mosued over
Do not reset sfx and anim when swapping between emotes. However, sfx is still dependent on preanim which shouldn't be happening
set focus to ic chat message when "set caption" is used in sfx list
Selecting SFX untied from preanims. This means if you select a SFX, your preanim setting remains untouched.
Internally, having a custom SFX still enables preanim, so this is fully compatible with older clients.
Fix background ignoring the position argument meaning you can frequently see the wrong pos from what the server expects you to see
Fix position dropdown forcing the character's default position, even if it's not actually available to us in our dropdown
Fix crash if get_current_position is called before ActorData exists