Add new clampToBorder for samplers' wrapMode
#169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@johguenther I've been adding a new KHR_SAMPLER_CLAMP_TO_BORDER extension to expose this new wrapMode value. |
To be more specific about it applying only to image samplers. Also fix emphasis on parameter names.
Collaborator
Author
|
Actually, went through another extension rename, being more specific about it applying to image samplers. |
Collaborator
|
How about |
johguenther
requested changes
Oct 30, 2025
Collaborator
johguenther
left a comment
johguenther
left a comment
There was a problem hiding this comment.
looks good, only the usual nitpicking...
appendices/extension_index.txt
Outdated
| * <<extension_sampler_clamp_to_border_image2d, `KHR_SAMPLER_CLAMP_TO_BORDER`>>: `image2D` sampler wrapMode1, wrapMode2 support clampToBorder | ||
| * <<object_types_sampler_image3D, `KHR_SAMPLER_IMAGE3D`>>: `image3D` sampler subtype is supported | ||
| * <<extension_sampler_clamp_to_border_image3d, `KHR_SAMPLER_CLAMP_TO_BORDER`>>: `image3D` sampler wrapMode1, wrapMode2, wrapMode3 support clampToBorder | ||
| * <<extension_sampler_image_clamp_to_border, `KHR_SAMPLER_IMAGE_CLAMP_TO_BORDER`>>: |
Collaborator
There was a problem hiding this comment.
I see what you mean, this is indeed tricky as we have one extension for multiple samplers. I'd just keep this entry and primarily link to image1d, then link the bullets to the specific one.
I can simply make those changes if fine with you.
Collaborator
Author
|
@johguenther I should have been addressing all your comments. Feel free to re-review when you have time. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, here is a proposal to add support for
clampToBorderto ImageXD samplers.Default wrapping mode is still
clampToEdge.Default
borderColoris transparent black.Note that the feature seems to be widely available:
Worst case, this is something that should be implementable using programmable hardware.