-
Notifications
You must be signed in to change notification settings - Fork 2
Fix tests #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments. Also copy the PR description to the commit message of the main commit of this PR.
When a remote access test (s3, gcs) fails it leaves the env variables dirty. This impacts the subsequent tests. The cleaning cannot be done in a decorator because the execution flow is interrupted when the test fails. The best place for the cleaning is into the tearDown method.
|
popescu-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix broken tests.
When a remote access test (s3, gcs) fails it leaves the env variables dirty. This impacts the subsequent tests.
The cleaning cannot be done in a decorator because the execution flow is interrupted when the test fails. The best place for the cleaning is into the
tearDownmethod.TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html