Skip to content

Conversation

@tramora
Copy link
Collaborator

@tramora tramora commented Jan 23, 2026

Fix broken tests.

When a remote access test (s3, gcs) fails it leaves the env variables dirty. This impacts the subsequent tests.
The cleaning cannot be done in a decorator because the execution flow is interrupted when the test fails. The best place for the cleaning is into the tearDown method.


TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments. Also copy the PR description to the commit message of the main commit of this PR.

Thierry RAMORASOAVINA added 2 commits January 26, 2026 15:45
When a remote access test (s3, gcs) fails it leaves the env variables dirty. This impacts the subsequent tests. The cleaning cannot be done in a decorator because the execution flow is interrupted when the test fails. The best place for the cleaning is into the tearDown method.
@tramora
Copy link
Collaborator Author

tramora commented Jan 26, 2026

See the comments. Also copy the PR description to the commit message of the main commit of this PR.
the test was improved and the commit message also.

@tramora tramora requested a review from popescu-v January 26, 2026 14:49
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tramora tramora merged commit 0c1d5e6 into dev Jan 26, 2026
16 checks passed
@tramora tramora deleted the fix-tests branch January 26, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants