Skip to content

Conversation

@argoyle
Copy link
Contributor

@argoyle argoyle commented Aug 14, 2025

Updates several dependencies to their latest versions, including
upgrading Go to version 1.23.0. Notable changes include:

  • Added github.com/google/go-cmp v0.6.0.
  • Upgraded golang.org/x/mod to v0.27.0, golang.org/x/sync to
    v0.16.0, and golang.org/x/tools to v0.36.0.
    These updates improve performance, security, and compatibility
    with other libraries.

Fixes #394

Copy link
Collaborator

@benjaminjkraft benjaminjkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also update the CI configs to run Go 1.25, if getting that working is the goal here?

@argoyle
Copy link
Contributor Author

argoyle commented Aug 14, 2025

Of course

@argoyle argoyle force-pushed the chore/update-dependencies-to-latest branch from 6c77127 to 968a944 Compare August 14, 2025 18:23
@argoyle
Copy link
Contributor Author

argoyle commented Aug 14, 2025

There, removed 1.22 since the requirements in go.mod changed to 1.23

@argoyle argoyle requested a review from benjaminjkraft August 14, 2025 18:27
@benjaminjkraft
Copy link
Collaborator

Thanks! Fine to remove 1.22, can you update the changelog for that? Otherwise all looks good! (I believe the test failure is the flake fixed in #393.)

Updates several dependencies to their latest versions, including
upgrading Go to version 1.23.0. Notable changes include:
- Added `github.com/google/go-cmp` v0.6.0.
- Upgraded `golang.org/x/mod` to v0.27.0, `golang.org/x/sync` to
  v0.16.0, and `golang.org/x/tools` to v0.36.0.
These updates improve performance, security, and compatibility
with other libraries.

Fixes Khan#394
@argoyle argoyle force-pushed the chore/update-dependencies-to-latest branch from 968a944 to a80dec2 Compare August 14, 2025 18:40
@argoyle
Copy link
Contributor Author

argoyle commented Aug 14, 2025

Something like that?

@benjaminjkraft
Copy link
Collaborator

Thanks!

@benjaminjkraft benjaminjkraft merged commit 01cfbc3 into Khan:main Aug 14, 2025
5 checks passed
@argoyle argoyle deleted the chore/update-dependencies-to-latest branch August 15, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support go version 1.25

2 participants