feat: avoid error when subscription ID is not present #387
+96
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheina97
requested review from
StevenACoffman,
benjaminjkraft,
csilvers and
dnerdy
as code owners
cheina97
force-pushed
the
frc/unknownid
branch
4 times, most recently
from
773f345 to
c8db0fe
Compare
benjaminjkraft
approved these changes
Jun 28, 2025
Collaborator
benjaminjkraft
left a comment
benjaminjkraft
left a comment
There was a problem hiding this comment.
Thanks for the clear explanation and tests as well as the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the error triggered when a websocket message does not contain a subscription ID.
Check this issue #383
I have: