Matching in genqlient by Normalizing Paths #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbytecat
requested review from
StevenACoffman,
benjaminjkraft,
csilvers and
dnerdy
as code owners
benjaminjkraft
approved these changes
Mar 28, 2025
Collaborator
benjaminjkraft
left a comment
benjaminjkraft
left a comment
There was a problem hiding this comment.
I don't really have a good way to test this but it seems plausible!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the
genqlientlibrary, which uses thedoublestarpackage for path matching. The current implementation does not correctly match paths on Windows systems due to differences in path separators. I've implemented a simple fix by converting Windows-style backslashes (\) to forward slashes (/) before performing the match, allowing the path matching to work correctly across all platforms.#371
bmatcuk/doublestar#61