Conversation
Closed
1 task
Suxxxxhyun
approved these changes
Feb 18, 2025
Collaborator
Suxxxxhyun
left a comment
Suxxxxhyun
left a comment
There was a problem hiding this comment.
해당 PR의 알림기능은 애뮬레이터 UI에서 쓰이는 알람임을 확인 및 해당 동작이 이상없음을 확인하였습니다.
PR이 현재 구체적이지 않아 정확하게 어떤식으로 흘러가는지 파악하기 어려우나,
마무리까지 얼마남지 않았고 대면으로 확인하였기에 해당 PR은 빠르게 승인하겠습니다.
수고하셨습니다.
kbyunghoon
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 어떤 작업인가요?
html + javascript 로 조악한 ui를 만들었습니다
요청에 대한 결과나 데이터 변화 등을 화면에서도 볼 수 있게 sse를 적용했습니다.
#️⃣ 연관된 이슈
#337
💡 리뷰어에게 하고 싶은 말
✅GpsTracker는 추상화된 GpsSseSender 인터페이스를 써서 데이터 변화를 알립니다. 구현체인 SseSendWithKeepAliveEmitter에 클라이언트의 연결 요청과 서버의 호출 메서드를 구현했습니다.
🙏 아래 내용이 모두 충족 되었는지 확인해주세요 🙏
dev브랜치 병합 하셨나요?