Conversation
kbyunghoon
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 어떤 작업인가요?
알림 데이터 저장을 판단하는 로직(AlarmService) 자체가 이상해서.. 로직을 바꾸고, 조회하는 쿼리도 이상해서.. 쿼리도 바꿨습니다.
#️⃣ 연관된 이슈
#340
💡 리뷰어에게 하고 싶은 말
vehicleId가 일치하는 최신 알림 데이터를 조회해요!
알림 데이터를 저장하고 알림 요청을 보냅니다!
예전 로직은 당최 뭔 로직이었는지 기억도 안나네요,,
🙏 아래 내용이 모두 충족 되었는지 확인해주세요 🙏
dev브랜치 병합 하셨나요?