fix: 예외 처리로 원래 트랜잭션에 영향 없도록 하기#343
Merged
Conversation
Closed
1 task
kbyunghoon
reviewed
Feb 17, 2025
monicar-event-hub/src/main/java/org/eventhub/application/AlarmService.java
Show resolved
Hide resolved
kbyunghoon
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 어떤 작업인가요?
알림 데이터를 저장하고 내부 서버에 알려줄 때, 알림 관련 처리는 되든 안되든 기존 off 로직에 영향이 없도록 @transactional(propagation = Propagation.REQUIRES_NEW) 적용했는데요. 그게 안되는겁니다..
알고보니 던져진 예외를 알림 관련 선에서 해결해야 기존 로직에도 영향이 없었습니다(예외가 전파되지 않도록 해야하더라고요)
#️⃣ 연관된 이슈
#340
💡 리뷰어에게 하고 싶은 말
🙏 아래 내용이 모두 충족 되었는지 확인해주세요 🙏
dev브랜치 병합 하셨나요?