Conversation
Closed
1 task
kbyunghoon
approved these changes
Feb 16, 2025
Collaborator
kbyunghoon
left a comment
kbyunghoon
left a comment
There was a problem hiding this comment.
리뷰 확인해주세요. 리뷰 모두 제안일 뿐이니 참고만 해주세요
수고하셨습니다.
monicar-event-hub/src/main/java/org/eventhub/application/AlarmService.java
Outdated
Show resolved
Hide resolved
monicar-event-hub/src/main/java/org/eventhub/presentation/OnOffController.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 어떤 작업인가요?
off 요청시에 알림 대상인지 확인합니다
알림 대상이라면
로컬 테스트로 control-center에 요청가는 것까지 확인
#️⃣ 연관된 이슈
#306
💡 리뷰어에게 하고 싶은 말
커밋 feat: alarm 컨트롤러에서부터 feat: alarm 내부 서버 api 요청까지만 보시면 됩니다요!
event-hub 에도 src/resources/properties 디렉토리에 env.properties를 추가해주세요 노션 BE-page 마지막에 추가해놨습니다
🙏 아래 내용이 모두 충족 되었는지 확인해주세요 🙏
dev브랜치 병합 하셨나요?