Fix Timezone Issue #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The start date for Costcodle was set to September 21, 12AM in the local timezone. This resulted in the GameNumber changing dependent on the local timezone. Ergo, UTC-5 would be on game 494, and UTC+5 would be on game 495, rather than both being on the same game number. By setting the costcodleStartDate to October 21 in UTC+0, this issue is avoided and all users should experience the same game number regardless of local timezone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start date for Costcodle was set to September 21, 12AM in the local timezone. This resulted in the GameNumber changing dependent on the local timezone. Ergo, UTC-5 would be on game 494, and UTC+5 would be on game 495, rather than both being on the same game number. By setting the costcodleStartDate to October 21 in UTC+0, this issue is avoided and all users should experience the same game number regardless of local timezone.