Open
Conversation
|
Message on Pull Request should explicit. |
01-lets_get_started/01.cpp
Outdated
| } | ||
| } | ||
| private: | ||
| int side,column,row; |
Member
There was a problem hiding this comment.
There should be a new line before the public or private section.
01-lets_get_started/01.cpp
Outdated
| int main() | ||
| { | ||
| square obj; | ||
| obj.square_data(); |
Member
There was a problem hiding this comment.
Use better names; think:
- Does
objhave anything to do with the problem domain? - Isn't the function name
square_data()redundant for a class namedSquare? - Is a variable assignment must here?
Member
|
Consider following a pattern while writing commit/PR messages. For instance try to use the verb first like in these:
Note: capitalization of words |
Author
|
Please find 02.cpp file at generalise folder |
|
|
||
|
|
||
| #include <iostream> | ||
| #include "Square.cpp" |
Member
There was a problem hiding this comment.
There should be a line before using namespace std;
02-generalize/Square.cpp
Outdated
| top_bottomSide(draw_variable); | ||
| } | ||
| }; | ||
|
|
Member
|
Avoid accepting input using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indentation corrected in 2 index files of both folders.