ruby square progarme created#2
Open
vipinkattungal wants to merge 4 commits intoKeralaStartupMission:vipinkattungalfrom
Open
ruby square progarme created#2vipinkattungal wants to merge 4 commits intoKeralaStartupMission:vipinkattungalfrom
vipinkattungal wants to merge 4 commits intoKeralaStartupMission:vipinkattungalfrom
Conversation
Member
|
01-lets_get_started/01.rb
Outdated
| sl.times do | ||
| puts val | ||
| end | ||
| print '#' * hash |
Member
There was a problem hiding this comment.
This is a duplication of a previous line; perhaps try to make it a method & call it instead. Also make sure every variable has names that corresponds to the domain. For instance, sl or val may not be immediately obvious to what you were intending.
Note: The code is actually very good, I am actually very happy to see it. Its very simple & intuitive. And also without using any conditions! Thats a very nice attribute.
Member
|
Author
|
thank u broozz |
Member
|
Consider writing every message/communication in the project in proper English. Will help others who may collaborate with you without the context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruby square progarame