Skip to content

refactor: allow comment overlay native div props #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joep31 merged 1 commit into from
Jan 27, 2026
Merged

refactor: allow comment overlay native div props #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/components/comment-overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
import { type CSSProperties, type ReactNode, useRef, useState } from "react";
import {
type CSSProperties,
HTMLProps,
type ReactNode,
useRef,
useState,
} from "react";
import { useComments } from "../contexts/comment-context";
import type { Position } from "../types";
import { getRelativePos, normalizeRect } from "../utils/position";

const DRAG_THRESHOLD = 4;

export const CommentOverlay = ({ children }: { children: ReactNode }) => {
interface CommentOverlayProps extends HTMLProps<HTMLDivElement> {
children: ReactNode;
}

export const CommentOverlay = ({ children, ...rest }: CommentOverlayProps) => {
const {
overlayState,
registerComment,
Expand Down Expand Up @@ -109,7 +119,7 @@ export const CommentOverlay = ({ children }: { children: ReactNode }) => {
if (overlayState === "inactive") return children;

return (
<div data-overlay style={{ position: "relative" }}>
<div data-overlay style={{ position: "relative", ...rest.style }} {...rest}>
<div
ref={overlayRef}
// onClick={(e) => handleClick(e)}
Expand Down