Conversation
|
I can only add what deep stack recognizes. I don’t know if they recognize birds, but I haven’t looked. The primary focus of the project is for security cameras. There are some things that I filter out at low level. It is possible that birds is one of these. I’ll look into it when I have a chance.
… On Jan 12, 2021, at 2:07 PM, Mike Farrington ***@***.***> wrote:
Added support for "Bird" detection as its own category (not lumped into Animals).
You can view, comment on, or merge this pull request online at:
#7
Commit Summary
Add support for bird detection
File Changes
M AreaOfInterest.cs (3)
M CreateAOI.Designer.cs (2493)
M CreateAOI.cs (23)
M FrameAnalyzer.cs (6)
M MainWindow.cs (5)
Patch Links:
https://github.com/Ken98045/On-Guard/pull/7.patch
https://github.com/Ken98045/On-Guard/pull/7.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I think you misuderstand... I wasn't asking you to add support. I added support myself. It looks like I'm the first person to fork your code and work on it. DeepStack does recognize birds. I didn't want to add it simply to "Animals", because in normal circumstances birds could be quite common and trigger false alarms. I have chickens and I want to make sure they don't escape their run. You're able to view my changes and if you find them to be acceptable, you can merge them into your codebase.
|
|
Great! Just be aware that things are a work in progress. The code is reasonably messy. I’m working on cleaning it up but also new features
… On Jan 12, 2021, at 4:48 PM, Mike Farrington ***@***.***> wrote:
I think you misuderstand... I wasn't asking you to add support. I added support myself. I look to be the first person to fork your code and work on it.
DeepStack does recognize birds. I didn't want to add it simply to "Animals", because in normal circumstances birds could be quite common and trigger false alarms. However, I have chickens and I want to make sure they don't escape their run.
You're able to view my changes and if you find them to be acceptable, you can merge them into your codebase.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I have committed a number of changes you should be aware of. The main thing is I’m getting rid of the use of the .bin files in favor of using the registry. There were quite a few other changes as well.
I should have created a new branch before making these changes, but I forgot.
From: Mike Farrington [mailto:notifications@github.com]
Sent: Tuesday, January 12, 2021 4:49 PM
To: Ken98045/On-Guard
Cc: Ken98045; Comment
Subject: Re: [Ken98045/On-Guard] Add support for bird detection (#7)
I think you misuderstand... I wasn't asking you to add support. I added support myself. I look to be the first person to fork your code and work on it.
DeepStack does recognize birds. I didn't want to add it simply to "Animals", because in normal circumstances birds could be quite common and trigger false alarms. However, I have chickens and I want to make sure they don't escape their run.
You're able to view my changes and if you find them to be acceptable, you can merge them into your codebase.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#7 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACSQ24OZPH7WPSDQJ2LSAQTSZTUV7ANCNFSM4V73WBCA> . <https://github.com/notifications/beacon/ACSQ24JBEQLZ7MCBJRALW63SZTUV7A5CNFSM4V73WBCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFU7WMLY.gif>
|
|
There's no conflicts, so this one can be easily merged by pressing the "Merge" button. I have a much larger commit that is a hefty cleanup of the folder structures. I'll that onto your changes, test it out, and submit a PR for that one as well. |
|
As far as your configuration settings, I was thinking about them going into the SQL database, but the registry works fine as well. Speaking of that database... It'd be great to store the results from DeepStack as a 1:Many off of your tblMotionFiles. That way, you don't have to re-analyze as you navigate. I ran into a problem where I couldn't navigate while DeepStack was churning through a sizable backlog. Would you object to my adding EntityFramework at some point? First though, I'd like to redo the installer in WiX Toolset. The Visual Studio Installer that is in use has long ago been deprecated. It's a dead technology. I like to work around the periphery of a project and get to know it before I dive into the meat. One last thing... You need to decide what open source / indemnification license model you wish to use, and place that into a LICENSE file in the root of the project. I probably shouldn't even be working on it, from a liability standpoint, until such a document is in place. |
|
See below
From: Mike Farrington [mailto:notifications@github.com]
Sent: Thursday, January 14, 2021 3:34 PM
To: Ken98045/On-Guard
Cc: Ken98045; Comment
Subject: Re: [Ken98045/On-Guard] Add support for bird detection (#7)
As far as your configuration settings, I was thinking about them going into the SQL database, but the registry works fine as well.
Yes, I considered that as well. The support code for saving/retrieving settings would be about the same, but the registry seems like a simpler solution. If there is a need to change to SQL I’ll do that. For those people who are technical enough to use SQL it seemed like the Registry was more convenient to view (or alter/delete) settings all in one place. BTW, the settings are under HKCU\K2Software\On Guard in the 1.5.1 code I just uploaded (not a “Release”).
Speaking of that database... It'd be great to store the results from DeepStack as a 1:Many off of your tblMotionFiles. That way, you don't have to re-analyze as you navigate. I ran into a problem where I couldn't navigate while DeepStack was churning through a sizable backlog.
The motion stuff saved in SQL currently takes into consideration the area definitions. Maybe I could save the raw DeepStack output and then analyze them from there as time permits I’ll think about that. I haven’t had a problem with the DeepStack backlog, but I’m not saying it couldn’t happen.
Would you object to my adding EntityFramework at some point? First though, I'd like to redo the installer in WiX Toolset. The Visual Studio Installer that is in use has long ago been deprecated. It's a dead technology.
I don’t have a problem with EF, but I haven’t had a real need for it either (but maybe because I never got around to really learning it).
Yes, the Visual Studio Installer isn’t great, but it does a reasonably decent job (as opposed to 1-Click which is flat out annoying).
I like to work around the periphery of a project and get to know it before I dive into the meat.
One last thing... You need to decide what open source / indemnification license model you wish to use, and place that into a LICENSE file in the root of the project. I probably shouldn't even be working on it, from a liability standpoint, until such a document is in place.
Yes, I do need to update the open source stuff. I haven’t quite gotten to the point of deciding which license version to use yet, and it hasn’t been a huge priority (until it is one I guess).
Note that there are 2 big things on my agenda
(1) Get the direction of motion (to/from a set point in an area) going. I added the basic plumbing to track the recent history, but I haven’t gotten there yet. I’m also not sure how useful it will be, but is seems worth a shot.
(2) Convert everything to .Net Core and at the same time WPF. That is a much bigger challenge, but in the long run I think it will make things look better and be easier to maintain. The reason I haven’t done that already is that I haven’t used WPF much. I could/may take baby steps and just use .NET Core with Winforms. The .NET Core Winforms stuff may not be there 100% yet though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#7 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACSQ24KCDEWHBUC7YSCXNPDSZ55NZANCNFSM4V73WBCA> . <https://github.com/notifications/beacon/ACSQ24PSJBBC242RETIHGB3SZ55NZA5CNFSM4V73WBCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFVKP3ZI.gif>
|
|
Yes, I too wanted to move things towards .NET Core if possible. Or .NET 5. .NET Core isn't really ready for WPF yet. I have plenty of WPF experience, but wasn't going to mention that just yet. :) As for the registry, I suggest HKLM instead of HKCU. I don't think this is something will have multiple users on a system who want separate configurations. This plays a little into one of the first coding tasks I wanted to tackle... moving the file processing work out to a Windows Service so that the UI and Service are separate projects (sharing necessary code in a shared DLL). This is the kind of program someone who is security conscious would want to run as a service using a dedicated and restricted service account instead of LocalSystem which is essentially admin. Lastly, for the database MDF/LDF files, those really shouldn't be in Roaming. As that file grows, it'll make signing into and out of domain accounts slower as the files synchronize to the domain controller. A good place for that is in C:\ProgramData\On-Guard. However, the installer would need to make that folder have modify privileges by default. Again however, that would only be if you want to move away from per-user installations which I think is wise in order to run as a service. |
2 participants
Added support for "Bird" detection as its own category (not lumped into Animals).