Support more complex scripts with run-ts #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the utils/run-ts script by adding a fallback mechanism to compute the compiled JavaScript file path when the find command fails to locate it. This improves the robustness of TypeScript script execution.
- Adds logic to construct the bin path manually using path manipulation when
findfails - Maintains the existing error handling for when the compiled file truly doesn't exist
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the "run-ts" script to support running scripts that rely on more files, meaning the binFile may not be the only file compiled. It does this by keeping track of the pathname relative to the
srcdirectory and converting the pathname in the same waytscdoes.