Call CTO2GameClientShell's destructor correctly.#80
Open
rohit-n wants to merge 1 commit intoKatana-Steel:linux-x86_64from
Open
Call CTO2GameClientShell's destructor correctly.#80rohit-n wants to merge 1 commit intoKatana-Steel:linux-x86_64from
rohit-n wants to merge 1 commit intoKatana-Steel:linux-x86_64from
Conversation
Katana-Steel
requested changes
Oct 15, 2021
On Linux, the destructor is called when the program closes instead of when libCShell.so is unloaded, resulting in crashes. Instead, allocate CTO2GameClientShell on the heap when the library is loaded, then delete it in CClientMgr::TermClientShellDE. We also need to set a flag in CConsole when this happens, as PrintString incorrectly thinks i_client_shell is not null and would call OnConsolePrint from a null pointer when CClientMgr::Term calls ClientStringWhine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, the destructor is called when the program closes
instead of when libCShell.so is unloaded, resulting in
crashes. Instead, allocate CTO2GameClientShell on the heap when
the library is loaded, then delete it in CClientMgr::TermClientShellDE.
We also need to set a flag in CConsole when this happens, as PrintString
incorrectly thinks i_client_shell is not null and would call OnConsolePrint
from a null pointer when CClientMgr::Term calls ClientStringWhine.