Update dataTables.altEditor.free.js for BS5#225
Open
RichMcQuillen wants to merge 1 commit intoKasperOlesen:masterfrom
Open
Update dataTables.altEditor.free.js for BS5#225RichMcQuillen wants to merge 1 commit intoKasperOlesen:masterfrom
RichMcQuillen wants to merge 1 commit intoKasperOlesen:masterfrom
Conversation
Bootstrap 5(BS5) has breaking changes that prevent this from working. data-dismiss becomes data-bs-dismiss, etc...
This version is updated to work with the newer BS.
form-group also doesn't exist in BS5; I left it, and customized with css:
.errorLabel {
display: none;
}
.form-group {
margin-bottom: 4px;
}
I considered changing form-group to input-group; nah.
I also didn't like col-3 + col-8 =11, not 12, and didn't like the mobile scrolling for col-xs for phones.
So these are proposed changes, for you to review and/or accept reject. You can also make a bs4 vs bs5 version.
Outstanding product. Thank you for your hard work!!!
Collaborator
|
I think it is safer to create a separated branch for BS5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap 5(BS5) has breaking changes that prevent this from working. data-dismiss becomes data-bs-dismiss, etc...
This version is updated to work with the newer BS.
form-group also doesn't exist in BS5; I left it, and customized with css:
.errorLabel {
display: none;
}
I considered changing form-group to input-group; nah.
I also didn't like col-3 + col-8 =11, not 12, and didn't like the mobile scrolling for col-xs for phones.
So these are proposed changes, for you to review and/or accept reject. You can also make a bs4 vs bs5 version.
Outstanding product. Thank you for your hard work!!!