Open
Conversation
feat(api): raid - support passing multiple levels and pokemon+forms
Collaborator
|
Don't see too much wrong with this, however you can indeed already send multiple levels by sending multiple rows (which is more in-line with the way the tracking is actually managed) |
Contributor
Author
Hmm... Since you don't see too much wrong, can it stay as it is? Added a few more changes, some QOL and ability to GET/POST to profiles without swapping to them. |
Contributor
Author
|
At this point, I don't care if we ever merge that. Development looks dead to me. Going to throw other things to bag on the way, I find them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(api): raid - support passing multiple levels and pokemon+forms
feat(api): query.silent to mute messages in tracking POST
feat(api): extend get/post with optional param profile_no overriding currently selected profile pull
Description
Extended POST API used to create with non-breaking changes:
levelasint || []intlevelasint || []intand additional fieldpokemon_formwhich takespokemon_id, formas objects.silentarg is set, skip sending message to user, useprofile_noquery first thencurrent_profile_noduring creationprofile_noquery first thencurrent_profile_noMotivation and Context
Same as accepting multiple gyms, some fields make sense to be specified in single call -
level,pokemon && form. This makes sure we are pushing all changes in single HTTP request instead sending multiple and possible losing something on the way.How Has This Been Tested?
Tested on production using legacy and new API calls.
Screenshots (if appropriate):
Types of changes
Checklist: