Skip to content

Multiple changes to API#930

Open
lenisko wants to merge 11 commits intoKartulUdus:developfrom
lenisko:extend-egg-raid-api
Open

Multiple changes to API#930
lenisko wants to merge 11 commits intoKartulUdus:developfrom
lenisko:extend-egg-raid-api

Conversation

@lenisko
Copy link
Contributor

@lenisko lenisko commented Sep 8, 2025

feat(api): raid - support passing multiple levels and pokemon+forms
feat(api): query.silent to mute messages in tracking POST
feat(api): extend get/post with optional param profile_no overriding currently selected profile pull

Description

Extended POST API used to create with non-breaking changes:

  • egg: accept level as int || []int
  • raid: accept level as int || []int and additional field pokemon_form which takes pokemon_id, form as objects.
  • all tracking POST's when query silent arg is set, skip sending message to user, use profile_no query first then current_profile_no during creation
  • all trackings GET's try to use profile_no query first then current_profile_no

Motivation and Context

Same as accepting multiple gyms, some fields make sense to be specified in single call - level, pokemon && form. This makes sure we are pushing all changes in single HTTP request instead sending multiple and possible losing something on the way.

How Has This Been Tested?

Tested on production using legacy and new API calls.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

feat(api): raid - support passing multiple levels and pokemon+forms
@jfberry
Copy link
Collaborator

jfberry commented Sep 8, 2025

Don't see too much wrong with this, however you can indeed already send multiple levels by sending multiple rows (which is more in-line with the way the tracking is actually managed)

@lenisko lenisko changed the title feat(api): egg - support passing multiple levels Multiple changes to API Oct 4, 2025
@lenisko lenisko marked this pull request as ready for review October 4, 2025 14:35
@lenisko
Copy link
Contributor Author

lenisko commented Oct 4, 2025

Don't see too much wrong with this, however you can indeed already send multiple levels by sending multiple rows (which is more in-line with the way the tracking is actually managed)

Hmm... Since you don't see too much wrong, can it stay as it is?

Added a few more changes, some QOL and ability to GET/POST to profiles without swapping to them.

@lenisko
Copy link
Contributor Author

lenisko commented Dec 16, 2025

At this point, I don't care if we ever merge that. Development looks dead to me.

Going to throw other things to bag on the way, I find them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants